Rename `MON_ID` to `MON_OT_ID`

pret / pokecrystal

Disassembly of Pokémon Crystal

https://pret.github.io/pokecrystal/

2.06k stars 770 forks source link

Rename `MON_ID` to `MON_OT_ID` #1114

Closed SnorlaxMonster closed 3 months ago

SnorlaxMonster commented 5 months ago

The constant name MON_ID implies it relates to the ID number of the Pokémon itself; however, it actually refers to the Trainer ID number of the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it substantially more clear what its meaning is.

The original definition of MON_ID is preserved in macros/legacy.asm

vulcandth commented 3 months ago

Calling it MON_OT_ID would probably be slightly more consistent with the rest of the codebase, but that's just a nitpick.

Rangi42 commented 3 months ago

I agree MON_OT_ID would be slightly better, but it's fine as-is if you want to just merge.

mid-kid commented 3 months ago

I agree on MON_OT_ID, since we use the OT term everywhere.