Open Grate-Oracle-Lewot opened 2 weeks ago
I'm not well-versed enough in the AI code to know whether this change is correct or not, but I'd suggest proposing changes through PRs, and getting used to the flow of making those, as it'll be easier to comment on things if you have any suggestions in the future.
"disapprove" sounds fine, though I'd look around the code in the same file to see if there's any similar functions with names you can borrow.
Generally, with the smart AI,
dec [hl]
causes the move to be encouraged, andinc [hl]
for it to be discouraged. This even appears to be the case later in the same function, atAI_Smart_Curse.maybe_greatly_encourage
. But under.approve
,.greatly_encourage
, and.encourage
, we're given someinc [hl]
s. Am I misinterpreting something, or are these labels backwards?The fix would look something like this:
I don't know what to rename "approve" to besides "disapprove." I was told to make a PR about this, but that looks complicated and I want to make sure I'm not mistaken first.