Open GriffinRichards opened 2 years ago
Reopening to track breaking changes in preparation for Porymap 6
MAP_NUM
/MAP_GROUP
in a way that Porymap's Heal Location parsing doesn't currently handle.#define
. (https://github.com/huderlem/porymap/pull/606)
This issue is for tracking a few potential improvements that haven't been made because they would require changes to Porymap. This way if it's decided one breaking change should be made the rest can be easily referred to and piled on.
object_event_graphics_info.h
could be made more readable and less prone to errors from missing a field by using designated initializers (see #1413). Porymap is currently unable to parse this.graphics/pokenav
are organized into subfolders, except for those read/written by Porymap whose paths would need to be updated. See #1636dest_warp_id
field because Porymap treats this as an int and won't properly handle macro names. See #1755include/constants/heal_locations.h
aren't preserved by Porymap, which prevents addingHEAL_LOCATION_NONE
. See #1671data/tilesets.s
is still in assembly is because Porymap expects it to be. Related: #1736MAP_NONE
is more accuratelyMAP_DYNAMIC
, andMAP_UNDEFINED
would beMAP_NONE
. This could be updated, but Porymap currently hard codes "MAP_NONE
" as "None" and expects any otherMAP_
constant in a warp destination field to be a valid map, or it rejects the event. See #1755