pret / pokeemerald

Decompilation of Pokémon Emerald
2.28k stars 2.55k forks source link

[Build System Rewrite] Sorted and cleaned up `graphics_file_rules.mk` #1956

Closed Icedude907 closed 1 month ago

Icedude907 commented 11 months ago

Description

Rewrote most of graphics_file_rules.mk and sorted rules alphabetically. Some dead code has been removed. Includes a destinction between input and output directories (although they are the same for the moment).

The motivation behind this is to make the file easier to browse and parse for newcomers.

Discord contact info

icedude907

GriffinRichards commented 2 months ago

Aside from adding comments I'm not sure this is worth it if we're not going to merge the later changes that make use of the distinction between input/output directories. With a few exceptions this file is largely populated with rules that should be ignored by downstream users (because they're just for matching) so I don't think we need to worry that much about sorting the entries.