pret / pokeemerald

Decompilation of Pokémon Emerald
2.2k stars 2.38k forks source link

Incorrect FLAG_REMATCH_* constants #1960

Closed RainingChain closed 1 month ago

RainingChain commented 10 months ago

In .\include\constants\flags.h

// Trainer Rematch Flags
#define FLAG_MATCH_CALL_REGISTERED           0x15C
#define FLAG_REMATCH_ROSE                    0x15D
#define FLAG_REMATCH_ANDRES                  0x15E
#define FLAG_REMATCH_DUSTY                   0x15F

are incorrect.

It should be

// Trainer Rematch Flags
#define FLAG_MATCH_CALL_REGISTERED           0x15C
#define FLAG_REMATCH_ROSE                    0x15C
#define FLAG_REMATCH_ANDRES                  0x15D
#define FLAG_REMATCH_DUSTY                   0x15E

The flag is FLAG_MATCH_CALLREGISTERED + REMATCH* (from .\include\gym_leader_rematch.h)