Include gba/defines.h in gba/types.h

pret / pokeemerald

Decompilation of Pokémon Emerald

2.2k stars 2.36k forks source link

Include gba/defines.h in gba/types.h #1988

Closed mrgriffin closed 5 months ago

mrgriffin commented 5 months ago

If gba/types.h is included before gba/defines.h, it ends up declaring a variable named PACKED rather than specifying that BgCnt should be packed.

This occurs in src/mini_printf.c, and also apparently in a feature branch which is how this situation was detected (a multiple definition error at link time).

mrgriffin commented 5 months ago

Sorry, you don't actually have PACKED on that struct here. mb.