pret / pokeemerald

Decompilation of Pokémon Emerald
2.2k stars 2.36k forks source link

Fix hoenn pokedex palette being split in two #1990

Closed NTx86 closed 4 months ago

NTx86 commented 5 months ago

Description

bg_hoenn.pal was split into two palettes: bg_hoenn.pal and caught_screen.pal, this is because in pokemon caught screen it would use the same palette loaded from different offsets to flash the palette which got misinterpreted as two different palettes when its loading the same one at different offsets. The fact that this is one palette can be proven by the fact LoadPokedexBgPalette() loads bg_hoenn.pal as a 96 byte palette. The split palette causes issues when compiler doesn't put the palettes in the same order as listed in graphics.c, causing the code to load half of the hoenn pokedex palette and other half as garbage data.

Discord contact info

nt_x86