search

pret / pokeemerald

Decompilation of Pokémon Emerald
2.2k stars 2.36k forks source link

Use Only One Loop in RandomlyGivePartyPokerus #1991

Closed Kurausukun closed 4 months ago

Kurausukun commented 5 months ago

Description

Using a compound check instead of a nested loop is a bit nicer here. Also added missing SPECIES_NONE constant usage.

Discord contact info

kurausukun

GriffinRichards commented 5 months ago

That 0 doesn't represent a species, it's a null pointer.

Kurausukun commented 5 months ago

My bad, you're right. Forgot how GetMonData worked for a second there