Changed type1 and type2 to be consistent

pret / pokeemerald

Decompilation of Pokémon Emerald

2.2k stars 2.36k forks source link

Changed type1 and type2 to be consistent #2021

Closed pkmnsnfrn closed 1 month ago

pkmnsnfrn commented 1 month ago

Description

* Added constants TYPE_PRIMARY and TYPE_SECONDARY.

Changed instances of type1 to types[0].
Changed instances of type2 to types[1]

Discord contact info

psf

AsparagusEduardo commented 1 month ago

The constants are redundant imo. Functionally, there's not difference in battle between a Roxk/Ground and Ground/Rock mon, just the order of the types. Plus, if someone wants to add more types to the array, they shouldn't need to update the enum.