Fix defines in MAP_NUM and MAP_GROUP

pret / pokeemerald

Decompilation of Pokémon Emerald

2.2k stars 2.36k forks source link

Fix defines in MAP_NUM and MAP_GROUP #2023

Open Bassoonian opened 1 month ago

Bassoonian commented 1 month ago

Due to the inclusion of MAP_ in MAP_NUM and MAP_GROUP, references to maps with these macros were not searchable in-repo which leads to frustration for hackers who want to rename maps. This PR updates the macro.

IMPORTANT: I think this breaks PoryMap support (I haven't had the time to check yet), so we should be very careful and coordinate this change with a new PoryMap release.

Discord contact info

bassoonian

GriffinRichards commented 1 month ago

I think this breaks PoryMap support

For reading/writing heal location data, yes. Otherwise Porymap doesn't care about MAP_NUM/MAP_GROUP