search

pret / pokeemerald

Decompilation of Pokémon Emerald
2.28k stars 2.55k forks source link

Get rid of common syms #2040

Closed luckytyphlosion closed 3 weeks ago

luckytyphlosion commented 1 month ago

Also only build tools once per makefile usage, error out if the submakes fail (only make 4.2+), print truncated link statement in terminal

Description

luckytyphlosion — 06/16/2019 okay so this is how a common symbol is defined: size <= 4: ALIGN by 4 4 < size <= 8: ALIGN by 8 size > 8: ALIGN by 16

then, define the symbol you can't simply replace it with a section like common_data because it doesn't align correctly it'll only align by 4 however, considering that ramscrgen just reads from the object file and manually outputs the symbols in the order they're defined based on common syms you could probably make common_data anyway, but repurpose ramscrgen to fix the alignment of common_data symbols and this would mean no common_syms/

Discord contact info

luckytyphlosion

GriffinRichards commented 1 month ago

Please fix the changes using .SHELLSTATUS to work for versions of Make < 4.2 or revert them. We don't need the error badly enough to break older versions of Make.