Added extra encoded character support - Githubissues

pret / pokeemerald

Decompilation of Pokémon Emerald

2.28k stars 2.55k forks source link

Added extra encoded character support #2050

Open AsparagusEduardo opened 2 weeks ago

AsparagusEduardo commented 2 weeks ago

Description

Changed default character from ? to ~ as to not confuse prints that use the "?" character.
Added support for CHAR_HYPHEN in mini_pchar_decode.
Added handling for CHAR_NEWLINE, CHAR_PROMPT_SCROLL, CHAR_PROMPT_CLEAR and CHAR_ELLIPSIS by adding multiple characters to properly print out what they're meant to print

I did this as part of a way to debug a different PR, so please let me know if this could be handled better and cleaner.

Discord contact info

AsparagusEduardo

GriffinRichards commented 4 days ago

I get that ~ isn't in the default font so it's less likely to appear in someone's decoded string, but I'd think ? is a clearer "unknown character" indicator as it's closer to the standard replacement character.