search

pret / pokefirered

Decompilation of Pokémon FireRed/LeafGreen
973 stars 555 forks source link

Wrong Songs in FireRed #320

Closed thewhitepikachu closed 4 years ago

thewhitepikachu commented 4 years ago

Hello , i just recently came across your blog and in the end , here, because i wanted to hack some pokemon game rom's so i can make my own custom changes and also go even a little deeper.

So, while i came across your blog, i also have came across the FireRed and LeafGreen source codes, which is awesome, but while i was checking them , i realised that the folder with the Songs, has the wrong music , is not the music from FireRed/LeafGreen, but Emerald.

Could you check and upload the corect Songs ? , if you still got the Source Codes. But either way , is fine, i mostly took the source code to see how it's writen, and to see the scripting part, because i want to custom that but i don't understand it very well yet.

Thanks.

PikalaxALT commented 4 years ago

Please elaborate on specifically which songs are incorrect. The FRLG music is there, I guarantee it.

thewhitepikachu commented 4 years ago

All of sounds (music) are from Emerald. Archive pokefirered-master Address : sound / songs / midi. Play them with winamp and see, i knew they are from Emerald because i played the gym fight song, and i was , ok, this is not kanto gym fight song, it's Emerald.

RevoSucks commented 4 years ago

Please join our discord at https://discord.gg/d5dubZ3 and I will inform you on why this is a very wrong train of thought.

PikalaxALT commented 4 years ago

This issue was caused by a misunderstanding of how MIDI soundfonts work. Closing.