search

pret / pokefirered

Decompilation of Pokémon FireRed/LeafGreen
973 stars 555 forks source link

make -jX not working with LeafGreen #600

Open Nachtfrische opened 1 year ago

Nachtfrische commented 1 year ago

When using the -j parameter with "make leafgreen", I'm getting the following make warning about it using -j1. make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.

grafik

This does not appear when just using "make -j16" for FireRed. Therefore, building LeafGreen is way slower.

Meister-anon commented 1 year ago

Is it possible you're using a older repo, I just used that command and it built without problem? or maybe there is some more recent issue, my fork is a month old.

edit: I even built twice to make sure it was actually using the faster speed, and it was indeed far faster than just -j1. so its working as it should for me.

Meister-anon commented 1 year ago

Screenshot (2715) - Copy

Nachtfrische commented 1 year ago

I've cloned the repo four days ago, I had the same issue back then. Could perhaps be a regression on the newer versions. I'm also using WSL2, not sure if that is related though.

It works for FireRed, not LeafGreen though.

grafik

Acimut commented 1 year ago

I did a test build of pokefirered using time make compare_firered -j6 between Ubuntu 22.04 and 20.04. In the first one I got the error that I mention here, while in the second one it didn't, as you can see in the video that I leave you below (5:16). https://www.youtube.com/watch?v=c-9Kt1FcUH0

You can also see that the build on Ubuntu 20.04 was faster (20 seconds) vs Ubuntu 22.04 (29 seconds) due to the -j issue.

Acimut commented 1 year ago

You can use -j$NPROC instead of -jX using the full capacity of the CPU and it will not give any problems. It's not a definitive solution, but it's something. Checked on WSL2 Ubuntu 22.04 with time make compare_firered -j$NPROC