search

pret / pokefirered

Decompilation of Pokémon FireRed/LeafGreen
973 stars 555 forks source link

Make JASC palette reading CR/LF agnostic #618

Closed waterwheels closed 1 year ago

waterwheels commented 1 year ago

When I tried exporting a .pal file from Aseprite, it produced a "0100" palette like this utility specifies, but it used \n instead of \t\n, and included the alpha channel in addition to the colour channels. Aseprite is a common pixel art tool, so I though it would be helpful if gbagfx could handle parsing these palettes as well.

I have very little experience with C, but I have tested this modification with both stock .pal files from the pkmnfirered repo and Aseprite .pal exports to confirm it handles both. Still, I'm not sure I haven't done something terrible, so ir would be worth reviewing.

waterwheels commented 1 year ago

I have done a refactor of this whole pull request, and I'm not sure if it would be better to squash the branch into one commit for clarity?

waterwheels commented 1 year ago

I think I've messed up this history, i'm going to close the pull request and see if i can clean it up