pret / pokegold-spaceworld

Disassembly of the Pokémon Gold and Silver 1997 Space World demo
344 stars 59 forks source link

Port refactorings and formatting from pokered/pokegold/pokecrystal #69

Open Rangi42 opened 4 years ago

Rangi42 commented 4 years ago
Rangi42 commented 4 years ago

Some chunks of code, like VBlank, clearly evolved from pokered to pokegold, with pokegold-spaceworld being somewhere in the middle. While disassembling spaceworld, it would be a good opportunity to sync pokered and pokegold. For example, AutoBgMapTransfer == UpdateBGMapBuffer, VBlankCopyDouble == Serve1bppRequest, etc. (In general Gen 1 has been getting refactored to be more like Gen 2, which would apply to conventions like "BG" instead of "Bg", but there are also pokered labels worth syncing to pokegold+pokecrystal.)