search

pret / pokegold-spaceworld

Disassembly of the Pokémon Gold and Silver 1997 Space World demo
344 stars 59 forks source link

Fill in named constants & values for moves #76

Closed ghost closed 3 years ago

ghost commented 3 years ago

How does one "percent" Rollout's accuracy value of 78.5?

ketsuban commented 3 years ago

Get as close as you can with {integer} percent, then add/subtract a small quantity to get the exact value. There's plenty of cases of percent + 1 and percent - 1 in pokecrystal.

Rangi42 commented 3 years ago

Some common percent values: https://github.com/pret/pokecrystal/blob/master/macros/data.asm#L3

ghost commented 3 years ago

So, is this okay? Or is there a better way: I edited the "move" macro to allow for "percent - \8" as needed. Sorry, I'm a noob! haha.

Rangi42 commented 3 years ago

@jd-0 Since not all the values can be represented as clean percentages, unlike the final, I would just make the macro a simple db \5 and repeat percent for all 251 moves.

ghost commented 3 years ago

I think I got it now, thanks for clarifying!

Rangi42 commented 3 years ago

Thank you! One more thing: please align the number columns so that the one's place is lined up; note how pokegold/pokecrystal do it.

ghost commented 3 years ago

There we go, much nicer!