search

pret / pokegold-spaceworld

Disassembly of the Pokémon Gold and Silver 1997 Space World demo
350 stars 59 forks source link

Kanto Mon Names #79

Closed ghost closed 3 years ago

ghost commented 4 years ago

Relabeling Kanto mons to have their canon English names, being consistent with pokegold/red/etc addressing issue "Japanese vs. English label names #77"

TODO: Rename dirs/files, examples: gfx/pokemon/fushigidane/front.pic gfx/pokemon/fushigidane/back.pic gfx/intro/lizardon_1.2bpp

Fix this (??): dex_order_alpha

Align comments (Or remove them??), ex: menu_icons pokemon_constants

Rangi42 commented 4 years ago

Thanks for getting this started!

Constant value comments should stay, but they don't need the now-redundant English names. So const MON_DROWZEE ; 30 DROWZEE could just be const MON_DROWZEE ; 30, and so on. They should still be aligned if they already were.

ghost commented 4 years ago

Anything else I'm missing? Do I need to re-order dex_order_alpha at all? Files and folders need renaming too still, yes?

Rangi42 commented 4 years ago

Yes, the TODO items you listed should be added, including renaming the DEX_* constants just like all other mentions of the 001-151 Japanese names.

ghost commented 4 years ago

Cool, I think this is ready now!