Open luckytyphlosion opened 1 year ago
I don't see a reason to include underscores in the unk
vars if nothing else has them.
imo no underscore in unknown fields, again this is already in the style guide, I just haven't gone through and fixed it all yet
Hi, snakehead (Python programmer) here. snake_case is beautiful and any attempts to eliminate it will be met with Protean Arceus.
imo no underscore in unknown fields, again this is already in the style guide, I just haven't gone through and fixed it all yet
I use underscore in BattleContext to differentiate it from unknowns in BattleSystem since it's much easier to control and replace that way without conflicts lol
imo no underscore in unknown fields, again this is already in the style guide, I just haven't gone through and fixed it all yet
I use underscore in BattleContext to differentiate it from unknowns in BattleSystem since it's much easier to control and replace that way without conflicts lol
That sounds like you need a better way of distinguishing the fields.
imo no underscore in unknown fields, again this is already in the style guide, I just haven't gone through and fixed it all yet
I use underscore in BattleContext to differentiate it from unknowns in BattleSystem since it's much easier to control and replace that way without conflicts lol
That sounds like you need a better way of distinguishing the fields.
No like I would cntrl + f and replace the unkowns constantly and it was much easier to do so when I wasn't accidently replacing the wrong unkA40
or whatever
yes so do something like unk_z_A40 or something
I personally prefer snake_case, no underscores in unknown variables/members
I prefer camelCase in general, though I feel it would be useful to have unknown fields to stand out with a different style specifically to make people document them.
On the record:
Donnel — Today at 10:10 PM I’m for camelCase Lhea — Today at 10:10 PM I'm for camelCase (ignore that I haven't worked on pokeplatinum lately)
This issue has had no activity for 60 days and will be marked stale. If there is no further activity, it will be closed in 30 days.
Useful grep to find instances:
grep -Pwr --include="*.c" --include="*.h" "[a-z_]+_[a-z_]+[,;\)]" --exclude-dir="tools" --exclude-dir="sub" --exclude-dir="lib" --exclude-dir=".github" --exclude-dir="files"
Do not apply this logic to Nintendo Libraries.
Local variable example
Good:
Bad:
Function parameter example
Good:
Bad:
Struct field example
Good:
Bad:
Exception: unknown fields. There is no consensus whether unk fields should have an underscore between the
unk
and the offset value (and probably other stuff)