search

pret / pokeplatinum

Decompilation of Pokémon Platinum
164 stars 56 forks source link

Poketch System Part 2 #209

Closed TrainerRiley closed 1 month ago

TrainerRiley commented 2 months ago

This is as far as I think I can get in this file before documenting a couple other core Poketch files.

lhearachel commented 2 months ago

A couple things upfront:

  1. Since this is a fresh review, could you squash out the merge commits with a rebase?
  2. Is the separate author intentional?
TrainerRiley commented 2 months ago

Alright, cleaned up the history here. This history is still a little messed up (probably as a result of my failed rebase attempts yesterday), but it's only my changes now.

lhearachel commented 1 month ago

We reached consensus on the naming scheme for functions moving forward. Please prefix your documented functions in this PR with appropriate verbage, per the naming scheme: [<Module>_]<Imperative><Object>

TrainerRiley commented 1 month ago

Okay, most comments addressed (besides the the ones trying to get the nested ifs to match with &&s instead, still working on that).

TrainerRiley commented 1 month ago

Okay, I think we're good for real this time.