Yup, Still More Script Commands - Githubissues

pret / pokeplatinum

Decompilation of Pokémon Platinum

198 stars 63 forks source link

Yup, Still More Script Commands #262

Closed ravepossum closed 1 month ago

ravepossum commented 2 months ago

Documents and renames the following script commands:

ScrCmd_0D3 -> BufferTMHMMoveName
ScrCmd_0D4 -> BufferMoveName
ScrCmd_0DF -> BufferUndergroundGoodsName
ScrCmd_0E0 -> BufferUndergroundTrapName
ScrCmd_0E1 -> BufferUndergroundItemName
ScrCmd_0EC -> CheckWonBattle
ScrCmd_0ED -> CheckLostBattle
ScrCmd_2BC -> CheckDidNotCapture
ScrCmd_119 -> CheckPartyPokerus
ScrCmd_133 -> RegisterPoketchApp
ScrCmd_14D -> GetPlayerGender
ScrCmd_14E -> HealParty
ScrCmd_15B -> CheckBadge
ScrCmd_177 -> GetPartyCount
ScrCmd_19A -> GetPartyCountHatched
ScrCmd_19B -> CountAliveMonsExcept
ScrCmd_1AD -> Dummy1AD
ScrCmd_1E5 -> IncrementGameRecord
ScrCmd_1F7 -> SurvivePoison
Dummy1 -> Dummy1F9 (renaming per new dummy function naming scheme)

Also adds a new constgen enum for badges and renames the playerWonBattle script manager member to the more appropriate name battleResult.

ravepossum commented 1 month ago

Both comments should be addressed now, lmk if you had something different in mind.