pret / pokeruby

Decompilation of Pokémon Ruby/Sapphire
799 stars 224 forks source link

More simple NONMATCHING fixes: #786

Closed jackson2k2 closed 4 years ago

jackson2k2 commented 4 years ago

wild_encounter.c: port Feebas fix which was somehow in pokeemerald but not here.

battle/anim/unused_9.c: match sub_80CFE2C. When I came upon this function, the use of 8 and 9 specifically in array offset calculation reminded me of VS 2012 doing the same thing, but with negative numbers! So this guess on how to fix it became obvious and it worked. :) You might want to check other places where the for variable could be used for offset calculation, that could be the key to fixing some more NONMATCHINGs.

field_effect_helpers.c: port MATCHING fixes from pokeemerald.

tv.c: match sub_80C01D4. Secondary temp u16.