search

pretalx / ansible-pretalx

https://docs.pretalx.org/en/latest/administrator/
Other
9 stars 11 forks source link

BREAKING CHANGE: fix: update default branch to install plugins from #25

Closed MikkCZ closed 1 year ago

MikkCZ commented 1 year ago

Change the default branch to install plugins from to main, but also enable to change it to any other branch or tag.

fix #24

MikkCZ commented 1 year ago

Now I realize, changing from master to main might be a breaking change for someone. But it fixes installation of the "official" plugins from https://github.com/pretalx/.

MikkCZ commented 1 year ago

@rixx I am afraid the merge did not go as planned. The module parameters are got duplicated https://github.com/pretalx/ansible-pretalx/blob/46755f74b28f128e88b61f8cb4c6c5e53d897427/tasks/package.yml#L168-L177

MikkCZ commented 1 year ago

The result should be

git:
  repo: "{{ item.repository }}" 
  dest: "{{ pretalx_system_home }}/plugins/{{ item.name }}" 
  version: "{{ item.version if item.version is defined else 'main' }}" 
  key_file: "{{ pretalx_system_home }}/.ssh/id_rsa" 
  accept_hostkey: yes

I am not around my laptop with access to GitHub, so I cannot create a new PR right now.

rixx commented 1 year ago

Oh GitHub, thy merge conflicts.

rixx commented 1 year ago

Fixed in 2cae113c7305b1731cf45afaac83b8305bb29db4.

Somewhat an illustration of why I like small PRs in theory but not in bulk practice. It never seems to end quite well, unless provided with a strict list of order or multiple rebases (and GitHub refused to rebase this one, and I was too lazy to check it out locally).