pretalx / pretalx-docker

Docker setup for a complete pretalx installation. Community-sourced, not officially supported.
29 stars 39 forks source link

fix: pass environment variables down through supervisord #63

Open DASPRiD opened 2 months ago

DASPRiD commented 2 months ago

https://github.com/pretalx/pretalx-docker/pull/61 allowed setting GUNICORN_BIND_ADDR, but environment variables were never passed down through sudo into supervisord, so this had no effect.

This PR fixes that by passing all environment variables down to supervisord. This additionally allows to completely skip a config file and configure pretalx entirely through env variables instead.

For the time being until this is merged and released I have published a hotfixed version myself: https://hub.docker.com/repository/docker/dasprid/pretalx-standalone/general

almereyda commented 2 months ago

Just noting that due to multiple issues with this repository this week I was working on an extensive production-ready rewrite of the environment to remove the Supervisor altogether.

I am in process of commiting the changes and documenting their rationale, in so we can have a community-wide conversation about where to take this repository together.

https://github.com/pretalx/pretalx-docker/compare/main...allmende:pretalx-docker:main

Please look out for a related Pull Request within the day.

almereyda commented 2 months ago

Please find

for review and feedback.

rixx commented 2 months ago

@DASPRiD thank you for taking the time to look into this! Let's figure out how #64 is going to work out, and in case it's not getting merged, we can revisit this PR, I'd say?

DASPRiD commented 2 months ago

Sounds good to me.