pretalx / pretalx-public-voting

Public community voting on talk proposals
Other
3 stars 5 forks source link

Add initial German translation #17

Closed vmx closed 3 years ago

vmx commented 3 years ago

@rixx if you tell me how to properly add a the formal German translation file, I can also add that.

@astroidex Can you please have a look at the translation (or ping someone else to have a look)?

rixx commented 3 years ago

@vmx makemessages should create a de_Formal directory for you, or you could just copy the de_DE one. You can compare with pretalx core to see what it should look like.

Please let me know when you want this PR merged.

vmx commented 3 years ago

@astroidex I've updated the translation.

I took your review (thanks!) and took all the changes, except for one where I used what I propose in this comment. The full changes can be found here: https://github.com/pretalx/pretalx-public-voting/pull/17/commits/e152167a43d31123e2a75ec7e722134b58da38e7

I also found more typos/bugs. Those changes can be found here: https://github.com/pretalx/pretalx-public-voting/pull/17/commits/248b2078a86cea1217b21340840d863788102f8b

And finally I've added a formal translation (is that one used for the FOSSGIS?). In order to make the review easier, here the diff which only shows the difference between the formal and non-formal version: https://github.com/pretalx/pretalx-public-voting/pull/17/commits/502713951f9ab2db2ce0b3daead84fb10d3c3969

astroidex commented 3 years ago

fixed some typos. I like the formal version for FOSSGIS

vmx commented 3 years ago

@rixx This is ready to be merged. If it needs a rebase, let me know and I'll do that.

When this one is merged, the current state is good enough for the FOSSGIS. Could you please then deploy this version?

rixx commented 3 years ago

When this one is merged, the current state is good enough for the FOSSGIS. Could you please then deploy this version?

I've been continually deploying after every PR merge ;)

vmx commented 3 years ago

Looks like we broke something. I get a 500 on signup :-/ (i can have a look later tonight if it also happens locally)

rixx commented 3 years ago

No, that was me trying to fix the misformatted email. Fixed now.