Closed vmx closed 3 years ago
Running flake8
says "./pretalx_public_voting/forms.py:25:9: F841 local variable 'vote_url' is assigned to but never used".
In b7a17227, you made the email text translatable. Prior to that commit, the string was an f-string, so the vote_url
variable was substituted automatically. Now it is just a string, so without a .format(vote_url=vote_url)
, nothing will be replaced.
Thanks for the quick fix! I should really start run the proper tooling to find those things myself.
We can add flake8/isort/black to this repo as a github workflow. I'll look into that over the weekend.
In the email sent, the placeholders are not replaced by the actual content. Example:
I guess that has something to do with making it a translatable string.
@rixx Do you have an idea? Does it make sense to fix it or will it automatically be fixed if #1 would be implemented (I'd then just go ahead an implement #1)?