pretalx / pretalx

Conference planning tool: CfP, scheduling, speaker management
https://pretalx.com
Apache License 2.0
739 stars 206 forks source link

Fahrplan Atom feed generates incorrect Links #1022

Closed MacLemon closed 4 years ago

MacLemon commented 4 years ago

Current Behavior

Expected Behavior

Steps to Reproduce

  1. Use the Fahrplan Updates Atom feed to track changes
  2. For example: https://fahrplan.privacyweek.at/pw20/schedule/feed.xml
  3. It contains a link to the current changeset (which is exactly what we lust for)
  4. Click the link: https://cfp.privacyweek.at/pw20/schedule/=version=1.2

Results in a 404.

Context

Link is generated incorrectly:

https://cfp.privacyweek.at/pw20/schedule/=version=1.2

should actually be

https://cfp.privacyweek.at/pw20/schedule/?version=1.2

Manually correcting the link in the browser makes pretalx redirect correctly to

https://cfp.privacyweek.at/pw20/schedule/v/1.2/

Though actually actually, I'd expect that feed

https://fahrplan.privacyweek.at/pw20/schedule/feed.xml

which is running under the domain fahrplan.privacyweek.at to generate a link with the same domain name. For example https://fahrplan.privacyweek.at/pw20/schedule/?version=1.2 and https://fahrplan.privacyweek.at/pw20/schedule/v/1.2/ works just fine. (That may be a separate, more complex issue though.)

And what we'd really want to have would be a link to: https://fahrplan.privacyweek.at/pw20/schedule/changelog/#1.2 since we want to track the Changes to the Fahrplan. The diff between 1.1 and 1.2 is the more important info for us here.

Additionally: The Version number is displayed on the Fahrplan page, but it's not linked to the Changelog, which would make it more convenient to find. It's complicated. :-)

Your Environment

MacLemon commented 4 years ago

Thanks so much rixx, you just made the life of two PrivacyWeek Orga people so much easier!

Also, I apologise for my sub-par issue text. That thing with the fahrplan hostname is a specialty of our setup, and unrelated to pretalx.