search

pretenders / ployst

The ployst core repo
1 stars 0 forks source link

Writing the github provider pt I #10

Closed alexcouper closed 10 years ago

alexcouper commented 10 years ago

This replaces PR #7

Whilst this is still a work in progress, I think it'd be beneficial to merge - providing there aren't any issues with what has been done so far.

Note that I've changed the description of what recalculate does (see github/views.py).

I also have a question about how we want to handle security of API calls - I'll highlight the question in the PR.

alexcouper commented 10 years ago

Warning: This PR is starting to get pretty big...

txels commented 10 years ago

Done a quick first read with the little time I had. Will try to be more thorough and deep sometime later, and give it a play.

txels commented 10 years ago

Although there are some open comments, I am happy to merge this in the current state. Although there is one failing test due to a fixture that was not uploaded to version control. I am working on object ownership in a separate branch, I will decide between keeping this one open or merging it depending on whether my branch will benefit from this being already in.

txels commented 10 years ago

I decided to merge and build from here.