Closed alexcouper closed 10 years ago
Looks like a nice substantial piece of work. I'll properly review this within the next days.
I think I've dealt with all comments.
If not, let me know and I'll come back in to this.
Once this has been merged I'll look at asyncing the github hook process.
It all looks good. I'm trying to make the tests run, but there is one simple failure I can fix myself and merge
This almost completes the github provider flow. At the very least it shows the way it is going to happen.
The test found in test_end_to_end.py, which mocks out core responses shows it "working". However there are a few missing pieces before it can be used in reality:
Once these are done, the github provider should be working.
However, until we have the following, it won't be particularly useful:
Additionally, I think we should do the following clean up after we have got this working fully: