pretenders / ployst

The ployst core repo
1 stars 0 forks source link

Set heroku config in one command. #36

Closed alexcouper closed 10 years ago

alexcouper commented 10 years ago

Soon I'll move these out into a fabric like package.

txels commented 10 years ago

BTW in terms of credentials, what do I need in order to run these?

Also I realised that heroku is nowhere in requirements. We should have a requirements/deploy.txt or deploy-heroku.txt?

alexcouper commented 10 years ago

It's not something that I installed using pip. I got it here:

https://toolbelt.heroku.com/

I should probably add that to the docs...unless you know of a pipable alternative

txels commented 10 years ago

No I don't. Yes I'd add to docs.

txels commented 10 years ago

Cool. I can now push to heroku (I pushed develop). But with git push, the fabric task does not work:

$ fab heroku_deploy
[localhost] local: heroku config:set ON_HEROKU=true DJANGO_SETTINGS_MODULE=ployst.settings.heroku
 !    No app specified.
 !    Run this command from an app folder or specify which app to use with --app APP.
txels commented 10 years ago

It works if I shift things around like this:

@task
def heroku_configure():
    """
    Configure for a heroku deploy
    """
    local(
        'heroku config:add '
        'BUILDPACK_URL=https://github.com/ddollar/heroku-buildpack-multi.git'
    )
    local('heroku config:set ON_HEROKU=true DJANGO_SETTINGS_MODULE=ployst.settings.heroku')

@task
def heroku_deploy():
    """
    Push this branch to heroku to deploy it.
    """
    this_branch = local("git rev-parse --abbrev-ref HEAD", capture=True)
    local("git push heroku {0}:master".format(this_branch))

I.e. keep config separate from deploy. I cannot run config though for the same reason above. I'm guessing you have some local heroku config somewhere...

alexcouper commented 10 years ago

Strange, I wonder why. Does the configure command work for you after the reshuffle?

There may be some heroku settings we are missing... On 20 Mar 2014 21:02, "Carles Barrobés i Meix" notifications@github.com wrote:

It works if I shift things around like this:

@taskdef heroku_configure(): """ Configure local environment for a heroku deploy """ local( 'heroku config:add ' 'BUILDPACK_URL=https://github.com/ddollar/heroku-buildpack-multi.git' ) local('heroku config:set ON_HEROKU=true DJANGO_SETTINGS_MODULE=ployst.settings.heroku')

@taskdef heroku_deploy(): """ Push this branch to heroku to deploy it. """ this_branch = local("git rev-parse --abbrev-ref HEAD", capture=True) local("git push heroku {0}:master".format(this_branch))

Reply to this email directly or view it on GitHubhttps://github.com/pretenders/ployst/pull/36#issuecomment-38220719 .

txels commented 10 years ago

No, heroku config commands don't work for me. It can't figure out the app.

alexcouper commented 10 years ago

I think this is ready for a another glance at now...