search

pretix / pretix-covid-certificates

Other
0 stars 0 forks source link

Remove question when deactivating plugin / 24h certificate expiry #1

Open pc-coholic opened 3 years ago

pc-coholic commented 3 years ago

This should be merged with the next release of pretix core so the plugin can leverage the uninstalled()-routine.

We could also forgo this requirement and keep the plugin as compatible with pretix>=3.6 - the plugin itself would work, just the automatic cleanup upon plugin deactivation would not fire...

This also includes a new option to expire the QuestionAnswers every 24h hours. We should probably keep an eye on the performance of this operation and - if required - offload it onto a separate cronjob similar to the covid-shredder.

pc-coholic commented 2 years ago

While looking at the latest PR, I came across this thing...

Should we still bother with those two changes or just drop them?

raphaelm commented 2 years ago

Oh, I might have missed this PR entirely.

I think the uninstalled change still makes sense.

I think the covid_certificates_recheck_every_24h change does no longer make sense. It looks buggy (it just deletes everything at a more or less random time, possibly in the middle of the day?!?), and we've already solved the same problem in a much better way with the current expiry system.