search

pretix / pretix-passbook

Support for Apple Wallet/Passbook files in pretix
https://pretix.eu
Other
27 stars 19 forks source link

Move order_position.secret to back of card #32

Closed lesander closed 1 year ago

lesander commented 5 years ago

Currently, Pretix' order_position.secret is printed below the QR code. I would like to propose moving this code to the back of the card as a backField value.

This results in a cleaner-looking wallet item.

raphaelm commented 5 years ago

Hmm, I'm not sure about this. It looks a little cleaner, but makes things harder to debug, especially because it makes it impossible for humans to differentiate two tickets from the same order just from the first page.

@pc-coholic @rixx Any thoughts?

lesander commented 5 years ago

Thanks for the quick reply @raphaelm.

I guess the barcode.altText could contain the order.code. This is a fairly short code. The main reason I've submitted this PR, is because the current situation results in an altText that is wider than the generated QR code, which UI-wise isn't very neat.

However, these tickets will likely be scanned using a pretixSCAN app or other application, if employees at registration would need further details, they can always look it up in the app, or if desired open the back of the card on the customer's device.

For comparison: Universe shows a small order.code-like identifier below the QR code and Eventbrite does not show an identifier on the front but only on the back of the card.

rixx commented 5 years ago

How about truncating the secret to allow for differentiation between order positions?

raphaelm commented 5 years ago

I guess the barcode.altText could contain the order.code. This is a fairly short code. The main reason I've submitted this PR, is because the current situation results in an altText that is wider than the generated QR code, which UI-wise isn't very neat.

Hmm, the order code is not enough since multiple tickets can share it, but we could use the CODE-positionid schema that we already use in filenames. However, showing the secret has the big advantage that the secret can directly and uniquely be searched in pretixSCAN or similar apps, in case e.g. the camera is broken. Completely moving the code to the back makes this harder to use (and discover as a feature) for pretixSCAN users.

I like @rixx' idea of truncating the secret to e.g. 10 characters and displaying only them on the front and the rest on the back.

lesander commented 5 years ago

Thanks for pointing that out to me @raphaelm. I've implemented @rixx's suggestion.