search

pretix / pretix-passbook

Support for Apple Wallet/Passbook files in pretix
https://pretix.eu
Other
27 stars 20 forks source link

fix: display name independent from the seat #65

Closed moritzlerch closed 6 months ago

moritzlerch commented 6 months ago

I stumbled across a "bug" that makes the attendee name disappear when they have a seat linked to their ticket. In my opinion the name should still be displayed on the Wallet ticket even if the attendee has a seat assigned to themselves.

I'm wondering if this behaviour is wanted or not. The elif makes the name disappear if the order position has a seat linked. See:

https://github.com/pretix/pretix-passbook/blob/a9eacfc344576a40fd5183dd77f8fc7d0cd39acf/pretix_passbook/passbook.py#L321-L332

raphaelm commented 6 months ago

This is intentional, as there is incredibly limited space on the lass. With your PR, there is a risk of neither the seat nor the attendee name being really reable any more, which would be worse. We think the seat is important when you enter an event so you know where to go to. The name should still be included on the "back" of the pass