search

pretix / pretix-sepadebit

SEPA Direct Debit payments for pretix
Other
5 stars 7 forks source link

Change BIC check to lookup (Z#23149160) #36

Open ser8phin opened 5 months ago

ser8phin commented 5 months ago

Removing the payment BIC FormField and looking up the BIC corresponding to the IBAN instead, since it is no longer mandatory to provide the BIC

(german source: https://www.verbraucherzentrale.de/wissen/geld-versicherungen/sparen-und-anlegen/sepa-europaweite-regeln-im-zahlungsverkehr-11512)

I would have preferred to leave the field and make it optional, but there seems to be no indicator on those FormFields, even when setting required=False, but that's why for now the FormField declaration has only been commented out

ser8phin commented 5 months ago

I haven't yet been able to rule out, that we might have multiple hits on the bic table :scream: but then we'd only use the best match now, as in the one with the most digits from iban