pretix / pretix

Ticket shop application for conferences, festivals, concerts, tech events, shows, exhibitions, workshops, barcamps, etc.
https://pretix.eu
Other
1.81k stars 454 forks source link

Order of "order received" and "order paid" emails #1167

Open Zambiorix opened 5 years ago

Zambiorix commented 5 years ago

Sometimes the e-mail "order received, please make your payment before ..." is actually received after the payment has been made and a payment received e-mail has indeed been received..

It would be better if the "order received" e-mail would be queued for a few minutes, because often payment follows very soon. In that case both e-mails can be combined into one.

I have connected Pretix to Postmark for transactional e-mails, so it could be that e-mails end up in different queues at Postmark, but I cannot change that, so Pretix could handle that a bit better

raphaelm commented 5 years ago

The ordering issue is on postmark's side, I'm pretty sure of that (as long as you only use one celery worker). I'm not really sure we want to artificially delay that just to work around that.

It would be better if the "order received" e-mail would be queued for a few minutes, because often payment follows very soon. In that case both e-mails can be combined into one.

That's actually the best idea on how to get rid of the "two e-mail" problem so far, I'm still not sure if it's a good idea. The "order received" e-mail is our solid safeguard in case anything goes wrong: No matter what happens after that, the user has a confirmation of the purchase with a link to the order which is the only way to access the order again! If something breaks in the payment process, we're really happy that email went out immediately ;)

Zambiorix commented 5 years ago

But you agree that it is confusing for the customer when receiving the "please pay" e-mail after the "payment received" e-mail? Even if that is a problem of Postmark, it is an issue with every serious transaction e-mail service. They all work heavily multi-queued / threaded.

I would love to avoid writing middleware myself :-)

raphaelm commented 5 years ago

Yeah, I do agree it's a problem ;) I'll think about it :)

Zambiorix commented 5 years ago

:-) thanks