search

pretix / pretix

Ticket shop application for conferences, festivals, concerts, tech events, shows, exhibitions, workshops, barcamps, etc.
https://pretix.eu
Other
1.73k stars 431 forks source link

Improve order secret handling #4139

Closed luelista closed 1 week ago

luelista commented 3 weeks ago

after this is merged, our payment provider plugins can be refactored to use tagged_secret / get_with_secret_check instead of hashlib.sha1

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 78.10%. Comparing base (46b2214) to head (b185921). Report is 32 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4139 +/- ## ======================================== Coverage 78.09% 78.10% ======================================== Files 429 430 +1 Lines 60312 60503 +191 ======================================== + Hits 47098 47253 +155 - Misses 13214 13250 +36 ``` | [Files](https://app.codecov.io/gh/pretix/pretix/pull/4139?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix) | Coverage Δ | | |---|---|---| | [src/pretix/plugins/paypal2/payment.py](https://app.codecov.io/gh/pretix/pretix/pull/4139?src=pr&el=tree&filepath=src%2Fpretix%2Fplugins%2Fpaypal2%2Fpayment.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix#diff-c3JjL3ByZXRpeC9wbHVnaW5zL3BheXBhbDIvcGF5bWVudC5weQ==) | `29.95% <ø> (-0.15%)` | :arrow_down: | | [src/pretix/plugins/stripe/payment.py](https://app.codecov.io/gh/pretix/pretix/pull/4139?src=pr&el=tree&filepath=src%2Fpretix%2Fplugins%2Fstripe%2Fpayment.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix#diff-c3JjL3ByZXRpeC9wbHVnaW5zL3N0cmlwZS9wYXltZW50LnB5) | `51.01% <ø> (-0.07%)` | :arrow_down: | | [src/pretix/presale/views/order.py](https://app.codecov.io/gh/pretix/pretix/pull/4139?src=pr&el=tree&filepath=src%2Fpretix%2Fpresale%2Fviews%2Forder.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix#diff-c3JjL3ByZXRpeC9wcmVzYWxlL3ZpZXdzL29yZGVyLnB5) | `82.85% <100.00%> (+0.35%)` | :arrow_up: | | [src/pretix/base/models/orders.py](https://app.codecov.io/gh/pretix/pretix/pull/4139?src=pr&el=tree&filepath=src%2Fpretix%2Fbase%2Fmodels%2Forders.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix#diff-c3JjL3ByZXRpeC9iYXNlL21vZGVscy9vcmRlcnMucHk=) | `89.18% <94.44%> (+0.08%)` | :arrow_up: | | [src/pretix/plugins/paypal2/views.py](https://app.codecov.io/gh/pretix/pretix/pull/4139?src=pr&el=tree&filepath=src%2Fpretix%2Fplugins%2Fpaypal2%2Fviews.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix#diff-c3JjL3ByZXRpeC9wbHVnaW5zL3BheXBhbDIvdmlld3MucHk=) | `38.05% <0.00%> (+0.27%)` | :arrow_up: | | [src/pretix/plugins/stripe/views.py](https://app.codecov.io/gh/pretix/pretix/pull/4139?src=pr&el=tree&filepath=src%2Fpretix%2Fplugins%2Fstripe%2Fviews.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix#diff-c3JjL3ByZXRpeC9wbHVnaW5zL3N0cmlwZS92aWV3cy5weQ==) | `32.14% <0.00%> (+0.15%)` | :arrow_up: | ... and [24 files with indirect coverage changes](https://app.codecov.io/gh/pretix/pretix/pull/4139/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pretix)