Dark Mode Fixes - Githubissues

winsmith commented 5 years ago

Dark Mode comes with iOS 13 and every new build enables it. Since we use a lot of default controls, most of the system works as expected, so this PR just has to clean up a few edge cases.

In this PR we:

Move Color definitions into an Asset Catalog. This allows us to provide easy color alternatives for Dark Mode
Provide a Dark Mode enabled system background color. This fixes a display issue in Questions cells where there was white text on white background.
Provide a Dark Mode color for grayBackground, which fixes a display issue in search where the notice was white on very light gray background. The alternative color is instead a very dark background.

winsmith commented 5 years ago

@raphaelm / @johan12345 : I recommend you have a look at the Colors.xcassets file in Xcode if you want to tweak the colors or want to add more Dark Mode alternatives.

winsmith commented 5 years ago

Also this concludes my Sunday afternoon coding session. I'll have a look at syncing improvements soon as well. :D~

raphaelm commented 5 years ago

Thanks a lot!

pretix / pretixscan-ios

Dark Mode Fixes #23