prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.47k stars 255 forks source link

New rule "@typescript-eslint/quotes" #104

Closed ybiquitous closed 5 years ago

ybiquitous commented 5 years ago

Hi, I noticed that the new rule @typescript-eslint/quotes has been added since @typescript-eslint@2.1.0:

I'm prepared for opening a new PR to add this new rule to the @typescript-eslint.js:

https://github.com/prettier/eslint-config-prettier/blob/793aa76f9045a1aa9237558c343e64e957b56984/%40typescript-eslint.js#L4-L11

But I'm not sure whether we should modify also the "quotes" section in README. https://github.com/prettier/eslint-config-prettier/blob/v6.1.0/README.md#quotes

lydell commented 5 years ago

Hi!

I think we need to do the same as we did for babel/quotes.

https://github.com/prettier/eslint-config-prettier#quotes

(The following applies to babel/quotes as well.)

I think all that needs to be done is:

ybiquitous commented 5 years ago

Thank you! I will try it. 💪

ybiquitous commented 5 years ago

I opened the new PR #105. I would be happy if I could receive reviews. 😃