Update package.json repository field

prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.

MIT License

5.39k stars 255 forks source link

Update package.json repository field #199

Closed xg-wang closed 3 years ago

xg-wang commented 3 years ago

So the url shows up when yarn outdated

ref https://docs.npmjs.com/cli/v7/configuring-npm/package-json#repository

lydell commented 3 years ago

Hi!

Can you show what yarn outdated looks like before and after this change?
The current syntax seems correct according to the docs you linked to, other than that the docs don’t mention that npm seems to default to github: if omitted? Does yarn support explicit github:?
If yarn does not support this syntax, I think it should! Is there a yarn issue about this? Have you considered opening one?

xg-wang commented 3 years ago

Hey @lydell I think you're right the syntax is correct, sorry I missed that. It appears to be an internal package registry bug, not yarn / eslint-config-prettier issue.

Specifically, https://registry.yarnpkg.com/eslint-config-prettier generates the homepage and repository urls correctly, and yarn will use homepage url and fallsback to repository.url. The internal registry I was using did not parse "repository": "prettier/eslint-config-prettier" correctly :)

Sorry for opening PR too soon, I'll close this