search

prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.39k stars 255 forks source link

Move away from deprecated `eslint-plugin-standard` #207

Closed voxpelli closed 2 years ago

voxpelli commented 2 years ago

As discussed in https://github.com/standard/eslint-plugin-standard/pull/41 the eslint-plugin-standard has been deprecated for some time now but this config seems to still use it, but only for a single rule, standard/computed-property-even-spacing.

I can’t remember what standard itself replaced it with, but I’m sure we can figure that out.

lydell commented 2 years ago

Hi! Is there a benefit to removing it? If it doesn’t cause harm, we could just as well keep it around until there are more breaking changes to make. According to https://www.npmjs.com/package/eslint-plugin-standard the package still has 1.6 million weekly downloads.

voxpelli commented 2 years ago

There is nothing known to be wrong with the package, but as it’s deprecated it’s quite unlikely that it will be updated for ESLint 8, so probably good to replace it when you move to ESLint 8

lydell commented 2 years ago

Thanks!

Then I’ll just keep in mind that if that plugin is annoying when moving to ESLint 8 internally, we could remove it instead of spending time on fixing things for it.

MichaelDeBoey commented 2 years ago

@lydell I'll remove it in #201 then

lydell commented 2 years ago

Only if absolutely needed! No need for a breaking change unless we have to.

voxpelli commented 2 years ago

It doesn’t have to be breaking I think, the plug-in was deprecated because it was redundant nowadays, not because it was wrong.

It’s probably likewise redundant for you.

lydell commented 2 years ago

Removing "some-rule": "off" from this config is always a breaking change.