search

prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.39k stars 255 forks source link

Configuring to avoid only unresolvable conflicts #227

Closed luxaritas closed 2 years ago

luxaritas commented 2 years ago

Currently I am using eslint-config-prettier, but after discovering prettier-eslint I'm imagining it would be nice to let style defaults from eg Airbnb override prettier. However, my concern is that if I remove eslint-config-prettier then go the route of prettier then eslint --fix, that there may be some things that eslint won't fix but will error on, which if I try to change prettier would just revert, leaving me stuck.

First off, is this even a realistic concern to begin with? If so, could eslint-config-prettier expose a config which only disables rules which could create this situation? Or could I get the same effect by requiring this config directly and just keeping the rules disabled that can't be auto fixed (ie, removing the changes to rules that can be auto fixed so that my configuration can take precedence)?

Let me know if I'm completely off base here. Thanks in advance for any guidance.

JounQin commented 2 years ago

Maybe you want https://github.com/prettier/eslint-plugin-prettier with:

{
  "extends": ["plugin:prettier/recommended"]
}

See also https://github.com/prettier/eslint-plugin-prettier#recommended-configuration

luxaritas commented 2 years ago

That just winds up enabling this config, yeah? Which doesn't really address my question...

JounQin commented 2 years ago

That just winds up enabling this config, yeah? Which doesn't really address my question...

No, it also enables prettier/prettier rule.

prettier is just opinionated, maybe you want https://github.com/prettier/prettier-eslint

Please don't post question as issue next time.

https://github.com/prettier/prettier/discussions is for questions.

luxaritas commented 2 years ago

Oh, sorry! Missed discussions since I've been on mobile... I'll move there for further followup