search

prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.34k stars 251 forks source link

@typescript-eslint/block-spacing and @typescript-eslint/key-spacing are not turned off #242

Closed 8naf closed 1 year ago

8naf commented 1 year ago

Hi, I noticed in the index.js file that you have turned off two rules: block-spacing and vue/block-spacing, but you didn't turn off @typescript-eslint/block-spacing. Similarly, key-spacing and vue/key-spacing have been turned off, but @typescript-eslint/key-spacing has not. Is there a reason for this ?

lydell commented 1 year ago

Hi!

Those two @typescript-eslint rules are quite new and nobody has added them here yet. Would you like to make a PR?

ttionya commented 1 year ago

Hi, I created a PR #243 for this issue.

lydell commented 1 year ago

Released in v8.7.0.

8naf commented 1 year ago

@ttionya Thank you for creating the pull request. I forgot that I had also created this issue 😅.