Move removed rules to deprecated section

[regseb]

Move many rules to deprecated section:

• generator-star: This rule was removed in ESLint v1.0 and replaced by the generator-star-spacing rule.
• no-arrow-condition: This rule was removed in ESLint v2.0 and replaced by a combination of the no-confusing-arrow and no-constant-condition rules.
• no-comma-dangle: This rule was removed in ESLint v1.0 and replaced by the comma-dangle rule.
• no-reserved-keys: This rule was removed in ESLint v1.0 and replaced by the quote-props rule.
• no-space-before-semi: This rule was removed in ESLint v1.0 and replaced by the semi-spacing rule.
• no-wrap-func: This rule was removed in ESLint v1.0 and replaced by the no-extra-parens rule. The "functions" option in the new rule is equivalent to the removed rule.
• space-after-function-name: This rule was removed in ESLint v1.0 and replaced by the space-before-function-paren rule.
• space-after-keywords: This rule was removed in ESLint v2.0 and replaced by the keyword-spacing rule.
• space-before-function-parentheses: This rule was removed in ESLint v1.0 and replaced by the space-before-function-paren rule. The name of the rule changed from “parentheses” to “paren” for consistency with the names of other rules.
• space-before-keywords: This rule was removed in ESLint v2.0 and replaced by the keyword-spacing rule.
• space-in-brackets: This rule was removed in ESLint v1.0 and replaced by the object-curly-spacing and array-bracket-spacing rules.
• space-return-throw-case: This rule was removed in ESLint v2.0 and replaced by the keyword-spacing rule.
• space-unary-word-ops: This rule was removed in ESLint v0.10.0 and replaced by the space-unary-ops rule.

[lydell]

Awesome work!

How did you manage to find all of these? Did you run some tool?

[regseb]

I'm currently adding Prettier to my project so I'm using eslint-config-prettier to know which ESLint rules to disable. When eslint-config-prettier disables a rule that I don't have in my configuration: I checked that it's removed and moved it to the deprecated section.

[lydell]

Ok!

Just checking one more thing: Do you have a practical need for this, or did you make the PR more for like “correctness sake”?

[regseb]

I will not install the eslint-config-prettier dependency in my project. I use eslint-config-prettier as reference. I propose this PR to make my configuration consistent with the configuration of eslint-config-prettier.

[lydell]

I see! I think. It’s fine to use eslint-config-prettier just as a reference – I do that too in many projects.

How does this PR help you use eslint-config-prettier as a reference?

(Not questioning the validity of the PR, just trying to figure out the impact of this PR if any.)

[regseb]

Reference, in the meaning of documentation.

• To know all the rules of ESLint, I would go to the Rules Reference page.
• To know the rules to disable with Prettier, I would look the index.js file of eslint-config-prettier.

[lydell]

The index.js file of eslint-config-prettier contains the same set of rules both before and after this PR.

In other words, you haven’t explained how you use the information about which rules are deprecated in eslint-config-prettier.

[regseb]

My configuration has all ESLint rules (except deprecated or removed).

I looked all the rules in the index.js files (except the includeDeprecated ones) and set them to "off" in my configuration. When I got to the generator-star rule, I was surprised not to find it in my configuration. I checked the documentation and discovered that it was removed. With this PR, the deprecated and removed rules are grouped together in includeDeprecated so I can ignore them.