search

prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.34k stars 251 forks source link

Definition for rule 'prettier/prettier' was not found #266

Closed 6XGate closed 9 months ago

6XGate commented 10 months ago

The documentation does not give instructions on properly installing this configuration. It will results in Definition for rule 'prettier/prettier' was not found. It needs to tell the dev to install the prettier plug-in AND add it to the plug-in list.

lydell commented 10 months ago

Hi! Can you provide steps to reproduce this issue, please? eslint-plugin-prettier is not required for this config to be used.

6XGate commented 10 months ago

Just installed the config repo add extended the shareable config.

  1. yarn add --dev eslint-config-prettier
  2. Add the prettier to the extends array.
lydell commented 10 months ago

eslint-config-prettier is this repo. It’s a config that turns a bunch of rules off.

eslint-plugin-prettier is the repo over here: https://github.com/prettier/eslint-plugin-prettier. It’s a plugin that provides the prettier/prettier rule.

6XGate commented 10 months ago

sorry, put the wrong name in the list... it was support to be yarn add eslint-config-prettier.

lydell commented 10 months ago

I claim that it works.

Can you post full steps to reproduce to prove what happens?

lydell commented 9 months ago

Closing due to no response.

6XGate commented 9 months ago

Just got back on here, but the full setup is in a code base that I don't own and I never got an example working. Actually already thought this was closed.