prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.34k stars 251 forks source link

Fix ECMA version in internal ESLint config #270

Closed lydell closed 7 months ago

lydell commented 7 months ago

Our internal ESLint config says ecmaVersion: 2018, but still allows syntax from ES2019+ since we also use @babel/parser.

This PR changes to using the default parser, except for react and flow where we use babel (for JSX and type annotations).

At some point we could bump ecmaVersion to be able to use newer language features, but right now that’s an unnecessary potentially breaking change. We only test supported Node.js in GitHub Actions, but I just tested manually and eslint-config-prettier still works in Node.js 12 which is just two LTS behind. Given eslint-config-prettier’s popularity I see no reason to break that for now.

See the individual commits for details.