prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.34k stars 251 forks source link

chore: migrate to changeset for automatically releasing #278

Closed JounQin closed 6 months ago

JounQin commented 6 months ago

close #277

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: 7f261f698baece3202324ac41c38ad62030c0170

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lydell commented 6 months ago

Hi!

I don’t want to review. I trust you with this stuff.

Btw, if you wondered what package-real.json was for: I got obsessed with making npm packages smaller, so I generated a smaller package.json without all the crap that doesn’t matter in an npm package (scripts, devDependencies). That’s also why I truncated the readme file – I personally never read readmes on npmjs.com since they are always out of date. eslint-config-prettier has a lot of downloads, so we quickly reach terabytes of wasted bytes. (I didn’t minify the code, since that makes debugging and auditing harder.) But these things are up to you now.

JounQin commented 6 months ago

@lydell

I know what does the real file do, I've changed to use clean-pkg-json for this purpose.

For readme, I think it helps to read on npmjs or in node_modules directly.

Small size is great, but I think that doesn't need to be so strict.

Cheers. 🍻

lydell commented 6 months ago

Thanks for sharing clean-pkg-json! Looks great.

Regarding the readme: I find it kind of ironic that the readme is almost twice as big as index.js + bin/* 😄 But again, it’s up to you.

JounQin commented 6 months ago

I'll merge this PR as-is then.