search

prettier / eslint-config-prettier

Turns off all rules that are unnecessary or might conflict with Prettier.
MIT License
5.41k stars 254 forks source link

Disable react/self-closing-comp #83

Closed gaurav5430 closed 5 years ago

gaurav5430 commented 5 years ago

The current exclusion config for react seems to turn off a handful of jsx related rules. How do you decide which rules to turn off?

Is thereact/self-closing-comp rule a style related rule, should it be part of prettier exclusions?

Prettier seems to automatically correct this when saving, but while working on the file in the editor, i get 2 linting errors, one from prettier and another from airbnb config.

Please help me understand whether or not this is something that should be turned off by eslint-config-prettier? (I am still trying to understand what to expect from prettier and eslint-config-prettier)

lydell commented 5 years ago

Good point, we should add this one.

gaurav5430 commented 5 years ago

It seems like a small change, would you accept a PR for it ?

lydell commented 5 years ago

Released in v4.1.0.