prettier / plugin-pug

Prettier Pug Plugin
https://prettier.github.io/plugin-pug
MIT License
196 stars 44 forks source link

Bug: VSCode fails to format pug files with prettier@3.1.1 and higher #478

Closed ladown closed 1 week ago

ladown commented 9 months ago

Plugin Version

v3.0.0

Prettier Version

v3.1.1

Which frameworks are affected?

Node Version

v20.10.0

Which operating systems have you used?

Prettier config

{
  "plugins": ["@prettier/plugin-pug"],
  "tabWidth": 4,
  "singleQuote": true,
  "trailingComma": "all",
  "semi": true,
  "printWidth": 130,
  "useTabs": true,
  "jsxSingleQuote": true,
  "endOfLine": "auto",
  "bracketSameLine": false,
  "htmlWhitespaceSensitivity": "ignore",
  "pugAttributeSeparator": "none",
  "pugWrapAttributesThreshold": 1
}

Input

script.
  const obj = { test: 1};

Output or Error

There is no formatter for 'jade' files installed.

Expected Output

script.
  const obj = { test: 1 };

Additional Context

Hello!

I faced with the problem, that prettier@3.1.1 and higher causes the problem, that VSCode doesn't format Pug files with prettier. If we install prettier3.1.0 and lower it works fine. When we install prettier@3.1.1 and higher, we see next indicator in footer panel of VSCode:

image

When we try to format it with command Format Document, we will have the following notification:

image

I also tried to set default formatter in VSCode settings and it didn't not help me.

If we try to format .pug files from CLI, it works perfect

Shinigami92 commented 9 months ago

Can you identify if this is an issue with the plugin, or maybe with the prettier version https://github.com/prettier/prettier/blob/main/CHANGELOG.md#311

ladown commented 9 months ago

I tested this issue with other plugins and figured out, that its connected with the Prettier

mhabsaoui commented 8 months ago

Hi, Same here, I have installed Prettier and the Pug plugin as DevDeps. "@prettier/plugin-pug": "^3.0.0" "prettier": "^3.2.5"

When trying to indent, I get same suggestion window from VSCode for Jade :-/

Screenshot from 2024-02-16 20-01-14

PS:

ladown commented 8 months ago

Hello, @mhabsaoui !

Its a problem with prettier extension as i can see. Here you can learn more - https://github.com/prettier/prettier-vscode/issues/3253

As for me, i found a solution to add path to prettier config in VSCode JSON settings -- "prettier.configPath": "./.prettierrc"