search

prettier / prettier-eslint-cli

CLI for prettier-eslint
https://npm.im/prettier-eslint-cli
MIT License
539 stars 85 forks source link

feat: :package: Support ESLint 8 #431

Closed idahogurl closed 2 years ago

idahogurl commented 2 years ago

Closes #427 Closes #428

What: BREAKING CHANGE: Requires ESLint 8. ESLint 8 API changes caused the format function to now be asynchronous. Requires minimum Node 12 as required by ESLint 8

codecov-commenter commented 2 years ago

Codecov Report

Merging #431 (071b7fc) into master (afc22f5) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 071b7fc differs from pull request most recent head 54aa823. Consider uploading reports for the commit 54aa823 to get more accurate results

@@            Coverage Diff            @@
##            master      #431   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          158       157    -1     
  Branches        23        23           
=========================================
- Hits           158       157    -1
Impacted Files Coverage Δ
src/format-files.js 100.00% <100.00%> (ø)
src/messages.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afc22f5...54aa823. Read the comment docs.

idahogurl commented 2 years ago

@zimme Good catch! Further testing does need to be done. I just need to either add a test or test it on my own with a sample project.

idahogurl commented 2 years ago

Blocked by prettier/prettier-eslint#745 to get the overrideConfigFile option to work.

chrisbobbe commented 2 years ago

Thank you! For the record, this PR fixes

Is that right?

idahogurl commented 2 years ago

@chrisbobbe Good catch! Closes #303 Closes #304

kylemh commented 2 years ago

what a machine 🎉