prettier / prettier-eslint

Code :arrow_right: prettier :arrow_right: eslint --fix :arrow_right: Formatted Code :sparkles:
http://npm.im/prettier-eslint
MIT License
3.99k stars 171 forks source link

It doesn't work with eslint v8 #656

Closed vingeraycn closed 2 years ago

vingeraycn commented 2 years ago

Versions:

Have you followed the debugging tips?

Yes

Relevant code or config

prettier-eslint '**/*.{ts,tsx}' --list-different

What I did:

What happened: image

Reproduction repository:

Problem description: It doesn't work with eslint v8

Suggested solution: update with this document to adapting eslint v8.

pjg commented 2 years ago

Dropping here a related issue and a working pull request in coc-eslint for reference: https://github.com/neoclide/coc-eslint/pull/118

talko-cervello commented 2 years ago

Any updates?

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 14.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

shellscape commented 2 years ago

@kylemh thanks for taking this on. Is there any chance you can ping the part of the team in charge of prettier-atom? That's failing hard and they need an update.

idahogurl commented 2 years ago

@shellscape I'm not sure if the Prettier team works on any repo besides prettier. Kyle and I are just contributors on this project. With Atom being sunsetted on December 15, 2022, I don't think there will be further development on prettier-atom https://github.blog/2022-06-08-sunsetting-atom/

I suggest you move to another editor like VS Code. I made the switch years ago and I still run the Atom keyboard layout.

shellscape commented 2 years ago

Thanks for the reply. I'm waiting for Zed to mature and currently beta testing. I loathe VSCode. In the mean time, since prettier-atom is not being maintained and we do have until December this year, would be it possible to add a contributor that can keep it up to date? I'm happy to run my own fork but there's a community still out there in need.

idahogurl commented 2 years ago

@shellscape All someone needs to do is create a PR and then tag or message someone marked as a Collaborator to get it reviewed, merged, and deployed. That's what I did to become a collaborator.

P.S. I still miss Atom.

shellscape commented 2 years ago

@idahogurl we've tried. it's sat idle. https://github.com/prettier/prettier-atom/pull/1271

kylemh commented 2 years ago

While we're collaborators in prettier-eslint and prettier-eslint-cli, we're not collaborators in prettier-atom and have no way of pushing it forward for you.

shellscape commented 2 years ago

@kylemh understood. Shared that in the hopes that it might be passed onto other teams or core team members. is there a private prettier slack, discord, or mailing list for the teams that you could help out the community by sharing this situation? we're coming up against crickets on the outside over here.

kylemh commented 2 years ago

There is not. We're a random collection of people that do what we can, when we can. We do this work exclusively without communicating beyond what you see on GitHub.

Your solution may need to be forking it and fixing it yourself.

shellscape commented 2 years ago

Man, that's a bummer. Even on the webpack core team we had mechanisms for other non-core individual teams and groups of collabs to talk to one another. I would have thought the Prettier org would be more organized given how huge the project is within the developer community these days. But thanks for the clarification.

Your solution may need to be forking it and fixing it yourself.

Way ahead of you. But that doesn't mean that I'm not going to stop trying to help the larger Atom community.